Stacks - Jackie - API Muncher

[jackiewatanabe]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I used postman to try and get/see different search results, limit it to different result counts and view a specific recipe
Describe your API Wrapper. How did you decide on the methods you created?	my api wrapper has two methods: one to return up to 1000 search results and another to get one recipe. I decided on these two methods because there's no need to create a recipe, edit recipes, or delete recipes since it's pulling from already available sources.
Describe an edge case or failure case test you wrote for your API Wrapper.	wrote a test to check that a bad search will return an empty array
Explain how VCR aids in testing an API.	VCR allows you to call the API once and record that interaction so you dont have to keep making the same requests and avoid going over your limit
What is the Heroku URL of your deployed application?	jackie-muncher.herokuapp.com (alison tricked me into choosing a name that could be considered inappropriate...
Do you have any recommendations on how we could improve this project for the next cohort?	The instructions for the baseline requirements really confused me for some reason. I was making it a lot more difficult than what was actually expected.

[kariabancroft]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Looks good - though you don't ever want to check in the coverage files!! gitignore!
Comprehension questions	Yes
General
Rails fundamentals (RESTful routing, use of named paths)	Yes
Semantic HTML	Yes
Errors are reported to the user	Not really - if the recipe can't be found it seems like this will be an error with no specific user feedback. Also there is no error handling if the "hits" key doesn't exist in the response.
API Wrapper to handle the API requests	Yes - you seem to be covering the two major things you can do with the API . Did you find any other unique identifier for the recipe other than the URI? The show route looks pretty rough using this
Controller testing	Some - I'd like to see more testing. This would probably drive the development of the failure scenarios that you're missing above.
Styling
Foundation Styling for responsive layout	Yes - nice job using the different sizes to make your design more responsive
Search View	Good
List View	Good
Show View which opens in a new tab	Yes - though it does not open a new tab. You have a lot of duplication for each label, quantity and unit. How might you DRY up this view?
API Features
The App attributes Edaman	Yes
The VCR casettes do not contain the API key	Check
Overall	Nice job! Final product looks good. Focus more on error cases in a future project.