Alena's Foodster

[Spatterjaaay]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I read the documentation on Edamam Api website and then I tried to build queries in Postman to see how the JSON that was returned looked like.
Describe your API Wrapper. How did you decide on the methods you created?	I decided to write two methods in the end, one that return list of recipes and creates recipe objects with minimal attributes and then one that queries for a specific recipe and saves more details form the JSON.
Describe an edge case or failure case test you wrote for your API Wrapper.	I tested that my methods return an empty array if given bad parameters.
Explain how VCR aids in testing an API.	It helps us to conserve the amount of calls we are making to the api, because it saves the response in a cassette and uses it for testing purposes, instead of making a call each time each individual test is run.
What is the Heroku URL of your deployed application?	https://snack-central.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Maybe point out that the lib folder may not load to Heroku and that it could be a potential problem. Seeing the "something went terribly wrong" message is really traumatizing and it took me a while to debug.

[CheezItMan]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits, nice descriptive messages
Comprehension questions	Check, I'm sorry the error message was traumatizing for you. Just remember you always have the logs!
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Check, nice work with some view helpers!
Errors are reported to the user	You used 404 page if the resource didn't exist. Some styling would be nice </nitpick>
API Wrapper to handle the API requests	Check, nice how you included paging on the API call.
Controller testing	You do have some broken tests, like your search action is retrieving a list of recipes for a blank search instead of a redirect. Otherwise pretty good.
Styling
Foundation Styling for responsive layout	Responsive styling, check
Search View	Check
List View	Check
Show View which opens in a new tab	Not in a new tab, but you can do so with the option target: "_blank"
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key	One does have an app_id https://api.edamam.com/search?app_id=dc26f0f1&app_key=<EDAMAM_TOKEN>&r=http://www.edamam.com/ontologies/edamam.owl%23recipe_bad%20id!!! Whoops! Remember to exclude those in your test_helper.rb
Overall	Good work overall, a bit of work to do in testing, but it's responsive and works well.