AKZ Recipe App

[AlisonZ]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I mostly used Postman to see what was in the JSON on Edamam. I also explored the JSON a little bit in the rails console.
Describe your API Wrapper. How did you decide on the methods you created?	The methods I created were the ones to show a list of recipes and an individual recipe. Both methods generate the url to send to HTTParty based on what information I am looking for - either a list or an individual recipe.
Describe an edge case or failure case test you wrote for your API Wrapper.	I wrote a test that returns an empty array if the item searched for does not have any hits
Explain how VCR aids in testing an API.	VCRs do an HTTP request one time and store that information so that information can be used again and again in tests instead of doing a bunch of API calls
What is the Heroku URL of your deployed application?	https://akz-recipe-app.herokuapp.com
Do you have any recommendations on how we could improve this project for the next cohort?	Seems all good to me!

[CheezItMan]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Lots of commits, good, messages like. "please be what i want." probably aren't the most descriptive
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Good semantic HTMl
Errors are reported to the user	When thing go wrong they generally just fail, no redirects or flash error messages.
API Wrapper to handle the API requests	Check
Controller testing	No negative cases for the show action.
Lib folder testing	No testing of the recipe class. No negative case for finding a specific recipe (bad ID).
Styling
Foundation Styling for responsive layout	The home button overlaps on things when the screen gets small.
Search View	Check
List View	Check, I would make the images clickable.
Show View which opens in a new tab	Works, there is a significant amount of whitespace between the elements in the screen. The Dietary info is very far to the bottom, so much so it looks like a footer.
API Features
The App attributes Edaman	On Heroku the image and link are broken.
The VCR casettes do not contain the API key	Check
Overall	Not bad, you handled most of the requirements. Some more work on testing is needed, and time-permitting some style cleanup.