Queues - Hyunji Kim - Api-Muncher

[ricecakemonster]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I read Edamam's doc first, then used Postman to find out what kind of information is returned as search results.
Describe your API Wrapper. How did you decide on the methods you created?	I made wrappers to send the search queries that are needed to find right recipes. I need to use two wrappers. One for finding list of recipes and another one is to find a specific recipe.
Describe an edge case or failure case test you wrote for your API Wrapper.	it raises an ArgumentError when you try to search without a search keyword. When you try to search without the health options, it still returns result without causing error.
Explain how VCR aids in testing an API.	You can only send certain amount of free API search requests per day. VCR mimics the API server, and it helps developers save money. VCR acts as a server in case API server is down, so developers can get more accurate test results.
What is the Heroku URL of your deployed application?	https://ricecake-api-muncher.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	it doesn't seem like all the health options are working as Edamam document says. It will be nice to let the students know before they start the project.

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Well Done
General
Rails fundamentals (RESTful routing, use of named paths)
Semantic HTML	Mostly good - '/recipes' should be reserved for index.
Errors are reported to the user	Okay - does give error for search term that doesn't return any recipes, but error is 'no more recipes'. Does not handle if invalid uri is given for recipe show, application breaks.
API Wrapper to handle the API requests	Well Done
Controller testing	Some - Only tests positive cases, missing negative cases. Like if recipe(s) are not found
Styling
Foundation Styling for responsive layout	Well Done
Search View	Well Done
List View	Well Done
Show View which opens in a new tab	original recipe opens in new tab, what attribute do you need to add to the html tag to open it in a new one?
API Features
The App attributes Edaman	Well Done
The VCR casettes do not contain the API key	Well Done
Overall
	Nice work completing all required tasks to expectations. Biggest suggestion is to keep error handling in mind. How would you handle recipe show to handle errors?