Addie's API Muncher

[add2point71dots]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I first played with the API in postman to explore how the results were formatted. I tried queries for a list of recipes and for a specific recipe's details (q and r) to see what the results looked like.
Describe your API Wrapper. How did you decide on the methods you created?	I have two methods in my API wrapper: list_recipes and get_recipe, one for listing 10 results at a time for a particular search, and the other for getting info about a specific recipe. I only have two views in my site, and these methods corresponded with what I would be needing for each of these views.
Describe an edge case or failure case test you wrote for your API Wrapper.	I tested that EdamamApiWrapper.list_recipes would return an empty array when given a search term that didn't find any recipes.
Explain how VCR aids in testing an API.	VCR lets you save information about API queries so you can perform tests without querying the API each time. It makes your tests faster and limits the amount of queries you make, which is useful when the API you're using has a limit.
What is the Heroku URL of your deployed application?	https://addie-api-muncher.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	At some point it would be good to cover the types of challenges you might face deploying to heroku. Seems like there are lots of potential fixes out there for various issues and many (sometimes conflicting) opinions about which ones should be used/not. My own personal challenge was that I was a bit burnt out this week after betsy (and therefore I didn't attempt optionals and my code could definitely be cleaned up), but overall I think it's a fun project.

[CheezItMan]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commit, good error messages
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Good sensical routes, I would suggest taking out GET /recipes since the root path already does this.
Semantic HTML	Good semantic HTML
Errors are reported to the user	It reports when recipes couldn't be found
API Wrapper to handle the API requests	Well done
Controller testing	Nice trick with the before and after. What about a test for too large or an invalid a page value.
API testing	Again good work with before and after, You covered the positive & negative cases, great!
Styling
Foundation Styling for responsive layout	Responsive, although the footer isn't. In the show view some of the h2 elements should have some sort of background or outline to them as the background sometimes makes them harder to read (dark text on dark background).
Search View	Works
List View	Works (part of search view)
Show View which opens in a new tab
API Features
The App attributes Edaman	Check
The VCR casettes do not contain the API key	Check!
Overall	Overall nice work, I like the favicon. Good solid work on this one.