Queues - Danielle Birbal - API-Muncher

[birbalds]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I used HTTParty gem to get an array of a hash from Edamam. By providing my ID and TOKEN and a search term(using q as a key in query) I was able to get results.
Describe your API Wrapper. How did you decide on the methods you created?	I needed multiple results from a search term or filter so I made a find method, and in order to view an individual order the more efficient way was to create a show method that uses a URI to return 1 unique result.
Describe an edge case or failure case test you wrote for your API Wrapper.	I tested for bogus labels and page numbers.
Explain how VCR aids in testing an API.	Since most APIs have restrictions on the amount of requests from a user, VCR allows developers to test their code without using their API count.
What is the Heroku URL of your deployed application?	https://hunchmunch.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Should have more commits with more specific messages. I should be able to know exactly what feature or functionality was worked on, completed, taken away, etc. with that commit.
Comprehension questions	Well Done
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	Well Done
Errors are reported to the user	Mostly Good - Does break when I change the show page uri, how could you change it so that it still showed a view with an error if I entered the wrong search uri for a recipe?
API Wrapper to handle the API requests	Mostly good - do you need to create a new EdamamRecipe instance? Or could .find be a class method?
Controller testing	Well Done
Styling
Foundation Styling for responsive layout	Well Done
Search View	Well Done - One suggestion, center the image and title
List View	Well Done
Show View which opens in a new tab	❗️ Opens in the same tab, what attribute can you add to the link to make it open in a new one?
API Features
The App attributes Edaman	Well Done
The VCR casettes do not contain the API key	❗️ App key is exposed
Overall
	Great work accomplishing the required tasks. The site has a fun design and utilizes foundation well. My biggest suggestion would be to add error handling with the show page.