Skip to content

Conversation

@cecomfort
Copy link

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? Excellent! :)
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? We created a method named "letter_sentinel" in the Word class which has an argument of the guess. It checks to see if the guess is a letter within the word, or if the user guessed the whole word correctly. And finally returns the user's progress of guessing the word.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? In the method 'draw_top" we have a local variable calls tops which is an array of the different .txt files for the art. We do not need access to files outside of the draw method.
What code, if any, did you feel like you were duplicating more than necessary? Too many .txt files
Is there a specific piece of code you'd like feedback on? Best place to incorporate the difficulty level.

Copy link

@droberts-sea droberts-sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Word-Guess Game

What We're Looking For

Feature Feedback                                                                              
Created a Class to encapsulate game functionality. yes
Used methods to DRY up your code. yes
Created instance variables & local variables where appropriate. yes
Used Arrays to store lists of letters guessed. yes
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. yes
Created interesting ASCII Art. yes
Baseline
Regular Commits with meaningful commit messages. yes
Readable code with consistent indentation. mostly - see inline comments
Created a pull request with your name & a meaningful message. yes
Extras
Used the Colorize Gem. yes
User is not penalized for guessing the same word twice. yes
Multiple difficulty levels. yes
The program can accept the whole word in one guess. yes

Program is well-structured and easy to use. Excellent work overall!


def initialize (word)
@complete_word = word
@current_status = generate_dashes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch your indentation here.

require "colorize"
require 'random_word_generator'

class Word

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you've split Word out into a separate class here. This does a good job of separating game logic from the code to display a word, making the whole program more clear.

end_game
end

def make_a_guess

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, watch indentation. I would expect this method to be at the same level as the one above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants