-
Notifications
You must be signed in to change notification settings - Fork 24
Queues - Cara Comfort & Laura Melgarejo - Word-Guess #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
droberts-sea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Word-Guess Game
What We're Looking For
| Feature | Feedback |
|---|---|
| Created a Class to encapsulate game functionality. | yes |
| Used methods to DRY up your code. | yes |
| Created instance variables & local variables where appropriate. | yes |
| Used Arrays to store lists of letters guessed. | yes |
| Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. | yes |
| Created interesting ASCII Art. | yes |
| Baseline | |
| Regular Commits with meaningful commit messages. | yes |
| Readable code with consistent indentation. | mostly - see inline comments |
| Created a pull request with your name & a meaningful message. | yes |
| Extras | |
| Used the Colorize Gem. | yes |
| User is not penalized for guessing the same word twice. | yes |
| Multiple difficulty levels. | yes |
| The program can accept the whole word in one guess. | yes |
Program is well-structured and easy to use. Excellent work overall!
|
|
||
| def initialize (word) | ||
| @complete_word = word | ||
| @current_status = generate_dashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch your indentation here.
| require "colorize" | ||
| require 'random_word_generator' | ||
|
|
||
| class Word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you've split Word out into a separate class here. This does a good job of separating game logic from the code to display a word, making the whole program more clear.
| end_game | ||
| end | ||
|
|
||
| def make_a_guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, watch indentation. I would expect this method to be at the same level as the one above.
Word Guess
Congratulations! You're submitting your assignment.
Comprehension Questions