Skip to content

Conversation

@kellysouza
Copy link

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? Kelly was more of a driver. We tried dividing tasks and combining code. We found we were overlapping coding the main loop. We were clear from the beginning and open about our skills and limitations. Our working styles are very different, we still collaborated in a way that produce a successful program and even did extra enhancements.
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? We created a "hint" method, which shows one letter which the user has not guessed and suggests it to them. the input is the number of hints they had received (only 1 allowed per game), the correct answer and the array showing the letters they have guessed and not. The output is one random letter from the answer, which haven't guessed
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? we only used local variable in the actual portion of the code that is running the program and getting the initial user input.
What code, if any, did you feel like you were duplicating more than necessary? I feel like the easy, medium, hard loop probably has a simpler method we will learn in the future.
Is there a specific piece of code you'd like feedback on? the huge If loop? maybe how to write / draw out a better algorithm

@kariabancroft
Copy link

kariabancroft commented Feb 21, 2017

Word-Guess Game

What We're Looking For

Feature Feedback
Both Teammates contributed to the codebase. From the description it seems like Monalisa could do more of the driver role next time.
Created a Class to encapsulate game functionality. Yes - Game and GameLevel classes. I think you could potentially use a third which would encapsulate anything related to drawing the flower or drawing the output to the user. Nice job instantiating the GameLevel inside the Game class.
Used methods to DRY up your code. Yes - methods are named using the appropriate naming conventions.
Created instance variables & local variables where appropriate. By using (mostly) all instance variables, you're missing some opportunities to pass arguments and parameters around in your methods rather than having variables that would stay around forever.
Used Arrays to store lists of letters guessed. Yes - @guess_letter
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. Yes - used the sample method to pull from the list of possible words.
Programmed "defensively" to detect errors in user input. Yes! Used a regex to ensure the user input was a letter as well as a method to check for duplicate guesses.
Created interesting ASCII Art. Yes - Flower :-)
Baseline
Regular Commits with meaningful commit messages. Yes - though it does seem like you could practice committing more often
Readable code with consistent indentation. Yes - indentation looks good
Created a pull request with your name & a meaningful message. Yes - nice effort on the comprehension questions
Extras
Used the Colorize Gem. Yep!
User is not penalized for guessing the same word twice. Yes
Multiple difficulty levels. Yes. You could simplify the game difficulty levels by using a hash rather than several different arrays. Then the pick_word method would just need to take user input and pick a random word from the hash of words for each difficulty.
The program can accept the whole word in one guess. Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants