Queues - Erica Case - Solar System #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solar SystemWhat We're Looking For
|
| class Planet | ||
| attr_reader :name ,:travel_time, :length_of_day, :gravity_ratio, :mean_temperature# degrees C | ||
|
|
||
| def initialize(hash) |
There was a problem hiding this comment.
Good job re-working Planet#initialize to take a hash.
| end | ||
|
|
||
| def add_planet(planet) | ||
| if planet.is_a? (Array) |
There was a problem hiding this comment.
Nice work supporting both an array and a single planet in the same method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod in your class?To define my instance variables, making them usable within class.
| Describe an instance variable you used and what you used it for. | |
I used gravity ratio to calculate how much someone would weigh on the planet.
| Describe what the difference would be if your
SolarSystemused anArrayvs aHash. |The hash would be a hash of hashes. Planet names would be keys and I would send values to the Planet class methods.
|
| Do you feel like you used consistent indentation throughout your code? | |
Yes