Pagination works #99
Open
Pagination works #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bmp api wrapper
list view is working
I see chicken
tests are written
Bmp styling
CheezItMan
reviewed
Dec 4, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Good work getting the project completed. The only thing I could criticize would be the testing, but you know how to do testing, just didn't have time here.
Way to stick with it.
| def index | ||
| @search_term = params[:search_term] | ||
| @search_results = EdemamApiWrapper.list_recipes(params[:search_term]) | ||
| @search_results = Kaminari.paginate_array(@search_results).page(params[:page]).per(15) |
There was a problem hiding this comment.
Nice work getting Kaminari to do the pagination!
| <%= next_page_tag unless current_page.last? %> | ||
| <%= last_page_tag unless current_page.last? %> | ||
| </nav> | ||
| <% end -%> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CheezItMan I forgot to git add the changes last night. I got the pagination to work. I actually had it working last weekend and just forgot to reset the server I think. :)