-
Notifications
You must be signed in to change notification settings - Fork 153
Final version #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Final version #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good job! See specific comments for more detailed feedback.
<p className="entry-time">Replace with TimeStamp component</p> | ||
<button className="like">🤍</button> | ||
<p>{props.body}</p> | ||
<p className="entry-time">{props.timeStamp}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's where you'd use the provided Timestamp
component in order to format this into a friendly-to-read date
import PropTypes from 'prop-types'; | ||
|
||
const TimeStamp = (props) => { | ||
const timeStamp = (props) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to have modified this component. Also, React components by convention use capital letters as their names, so Timestamp
was correct.
<header> | ||
<h1>Application title</h1> | ||
<h1>Human & Robot</h1> | ||
<h2 className="like">LikeCount: {Hearts()} ❤️</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests were expecting this text to read "3 ❤️s", which is why you saw those tests fail.
Final version of react chatlog