Lions - Ivy S #120
Open
Lions - Ivy S #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… always get passed in with the tests
….id becuase sometimes the backend info given does not include id
alope107
reviewed
Feb 17, 2023
| @@ -1,16 +1,51 @@ | |||
| import React from 'react'; | |||
| import './App.css'; | |||
| // import ChatEntry from './components/ChatEntry'; | |||
There was a problem hiding this comment.
Remember to remove unneeded comments.
Comment on lines
+13
to
+18
| if (message.id === updatedMessage.id) { | ||
| return updatedMessage; | ||
| } | ||
| else { | ||
| return message | ||
| } |
There was a problem hiding this comment.
Small nitpick: the else is not needed here.
| <header> | ||
| <h1>Application title</h1> | ||
| </header> | ||
| <h1>Heard it Through The Ivy Vine</h1> |
Comment on lines
+13
to
+19
| const updatedMessage = { | ||
| sender: props.sender, | ||
| id: props.id, | ||
| body: props.body, | ||
| timeStamp: props.timeStamp, | ||
| liked: !props.liked, | ||
| }; |
There was a problem hiding this comment.
Consider using ... to make this more concise
Comment on lines
+46
to
+47
| liked: PropTypes.bool, | ||
| onToggleLike : PropTypes.func, |
| }; | ||
|
|
||
| ChatLog.propTypes = { | ||
| entries: PropTypes.array.isRequired, |
There was a problem hiding this comment.
Consider using arrayOf to make the prop types more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.