forked from AdaGold/hash-practice
-
Notifications
You must be signed in to change notification settings - Fork 76
Cedar - Kristin L #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kbhlee2121
wants to merge
2
commits into
Ada-C16:master
Choose a base branch
from
Kbhlee2121:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,98 @@ | ||
|
|
||
| def create_freq_map(word): | ||
| freq_map = {} | ||
| for char in word: | ||
| if char in freq_map: | ||
| freq_map[char] += 1 | ||
| else: | ||
| freq_map[char] = 1 | ||
| # convert to frozenset because it's hashable whereas dicts and sets are not | ||
| return freq_map | ||
|
|
||
| def grouped_anagrams(strings): | ||
| """ This method will return an array of arrays. | ||
| Each subarray will have strings which are anagrams of each other | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n^2) | ||
| Space Complexity: O(n) | ||
| Ideas | ||
| Have freq maps as keys and words as values in a list | ||
| dict = { | ||
| {"a":1, "t":1, "e":1}: ["ate", "eat", "tea"] | ||
| } | ||
| -> would need 3 hash tables: 1 for hash of hash tables of frequences, 2 dict has keys? | ||
| -> or create this dict example without creating another hash | ||
| PSEUDO | ||
| - Create empty dict | ||
| - Loop through each word in words and create freq map (maybe use a helper) | ||
| - if freq map not in dict, append to dict with freq map as key and word as value | ||
| - if freq map in dict, append word to value | ||
| - return dict values as list | ||
| """ | ||
| pass | ||
| word_dict = {} | ||
| for word in strings: | ||
| current_freq_map = frozenset(create_freq_map(word)) | ||
| if current_freq_map in word_dict: | ||
| word_dict[current_freq_map] += [word] | ||
| else: | ||
| word_dict[current_freq_map] = [word] | ||
|
|
||
| return list(word_dict.values()) | ||
|
|
||
| def top_k_frequent_elements(nums, k): | ||
| """ This method will return the k most common elements | ||
| In the case of a tie it will select the first occuring element. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n log n) | ||
| Space Complexity: O(n) | ||
| Ideas | ||
| Create freq map where keys are nums and value is the frequency | ||
| How to return the number with 1st, 2nd highest freq if k =2 | ||
| what if k=3 | ||
| PSEUDO | ||
| -Create freq map | ||
| freq_map = { | ||
| 1:1, | ||
| 2:3, | ||
| 3:2 | ||
| } | ||
| - have a max_count for max value -> | ||
| - could also maybe use slicing | ||
| -create empty list | ||
| - for i in range(k), append key that has max count | ||
| - decrement max_count | ||
| with duplicate max values: | ||
| - create max_list instead of a variable | ||
| - sort list | ||
| - slice list | ||
| - iterate through freq map and add values that match the sliced list elements to a set | ||
| to avoid duplicates | ||
| """ | ||
| pass | ||
|
|
||
| freq_map = {} | ||
| for num in nums: | ||
| if num in freq_map: | ||
| freq_map[num] += 1 | ||
| else: | ||
| freq_map[num] = 1 | ||
|
|
||
| freq_values = list(freq_map.values()) | ||
| # sorts values of freq map in descending order | ||
| freq_values.sort(reverse=True) | ||
| # k number of max frequencies. Assumes if k = 2, and there are more than one with the 2nd highest frequency | ||
| # ex output = [1,1,2,2,3,3,3] | ||
| # 1 and 2 are tied so they are both added to max_values and the output will have 3 elements in a list. output = [1,2,3] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this case, we've generally been expecting that you drop down to k even if there are ties, but this is a perfectly fine assumption to make, so I'm not going to ding you for it. |
||
| max_values = freq_values[:k] | ||
|
|
||
| answer = set() | ||
| for key, value in freq_map.items(): | ||
| for max in max_values: | ||
| if value == max: | ||
| answer.add(key) | ||
| return list(answer) | ||
|
|
||
| def valid_sudoku(table): | ||
| """ This method will return the true if the table is still | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When doing time complexity calculations, you can't really reuse the same variables to represent different factors. For example, here, you're using
nfor both the number of strings in the list, and the number of characters in the strings, which are independent factors. So this would more properly be O(n*m) wherenis the number of strings in the list, andmis the number of characters in the strings.However, we can also make an simplifying assumption since we know our input is a list of English words. Words in English don't get too long (5 letters per word on average), so the effect of the number of characters in the word is pretty bounded, especially compared to the number of words in the list (which could easily be hundreds or thousands of words). As such, we can just say the time complexity is O(n).