Maple Ayaka and Grace(Jiajia Wang) #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangjiajia95
changed the title
spitsfire
reviewed
Oct 9, 2021
| 'Z': 1 | ||
| } | ||
|
|
||
| LETTER_SCORE = { |
Comment on lines
+46
to
+51
| while len(letters) < 10: | ||
| random_letter = random.choice(string.ascii_uppercase) | ||
| if letters.count(random_letter) >= LETTER_POOL[random_letter]: | ||
| continue | ||
| else: | ||
| letters.append(random_letter) |
There was a problem hiding this comment.
interesting approach! I think it would be more efficient if we got rid of the continue since it isn't doing anything for the code, so maybe do something like this:
Suggested change
| while len(letters) < 10: | |
| random_letter = random.choice(string.ascii_uppercase) | |
| if letters.count(random_letter) >= LETTER_POOL[random_letter]: | |
| continue | |
| else: | |
| letters.append(random_letter) | |
| while len(letters) < 10: | |
| random_letter = random.choice(string.ascii_uppercase) | |
| if letters.count(random_letter) < LETTER_POOL[random_letter]: | |
| letters.append(random_letter) |
| pass | ||
| letters = [] | ||
| while len(letters) < 10: | ||
| random_letter = random.choice(string.ascii_uppercase) |
There was a problem hiding this comment.
instead of bringing another library, let's use what we already have! Maybe we can turn our LETTER_POOL into a list and randomly choose one of the keys:
Suggested change
| random_letter = random.choice(string.ascii_uppercase) | |
| random_letter = random.choice(list(LETTER_POOL)) |
| return letters | ||
|
|
||
|
|
||
| def uses_available_letters(word, letter_bank): |
There was a problem hiding this comment.
👍 wow short and sweet! nicely done
| def score_word(word): | ||
| pass | ||
| score = 0 | ||
| for letter in word.upper(): |
There was a problem hiding this comment.
good idea making sure that the letters and inputs will always be capitalized
| pass | ||
| max_score = 0 | ||
| for word in word_list: | ||
| score = score_word(word) |
| elif score == max_score: | ||
| max_score_word_list.append(word) | ||
|
|
||
| winner = select_winner(max_score_word_list) |
| return winner, max_score | ||
|
|
||
|
|
||
| def select_winner(word_list): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.