Scissors - Mariela C. #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
Apr 1, 2021
Comment on lines
+173
to
+176
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This is not a big deal, but for future reference, the norm is to have less spacing between pieces of code.
| popular_genre = get_most_watched_genre(user_data) | ||
| unique_movie = get_friends_unique_watched(user_data) | ||
|
|
||
| # for movie in unique_movie: |
There was a problem hiding this comment.
For future reference, its usually best to remove old commented code like this before committing and/or submitting
Comment on lines
+193
to
+194
| popular_genre = get_most_watched_genre(user_data) | ||
| unique_movie = get_friends_unique_watched(user_data) |
There was a problem hiding this comment.
Great job making use of other methods!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.