Rock - Nyckolle Lucuab #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy/pasted original wave 05 data in case of accidental changes
audreyandoy
reviewed
Apr 5, 2021
audreyandoy
left a comment
audreyandoy
left a comment
There was a problem hiding this comment.
Great job Nyckolle! You hit all the learning goals and your code was very neat and easy to read! Keep up the good work!!!
Comment on lines
+2
to
+6
| "python.testing.pytestArgs": [ | ||
| "tests" | ||
| ], | ||
| "python.testing.unittestEnabled": false, | ||
| "python.testing.nosetestsEnabled": false, |
There was a problem hiding this comment.
For future reference we will be adding files that are specific to your coding environment such as .vscode settings into a .gitignore. This is just to prevent conflicts with other peoples' settings when they work on the same project as you.
Comment on lines
+5
to
+7
| if movie_title == None or genre == None or rating == None: | ||
| return None | ||
| return {"title": movie_title, "genre": genre, "rating": rating} |
| for data in watchlist: | ||
| if data["title"] == movie: | ||
| watchlist.remove(data) | ||
| watchedlist.append(data) |
There was a problem hiding this comment.
This would be a good spot to call the add_to_watched function
Comment on lines
+32
to
+39
| for description, value in dict.items(): | ||
| if description == "genre": | ||
| if value in genre_tally: | ||
| genre_tally[value] += 1 | ||
| else: | ||
| genre_tally[value] = 1 | ||
| elif description == None: | ||
| return None |
| if description == "rating": | ||
| rating_total += dict[description] | ||
| ratings.append(value) | ||
| avg_rating = pytest.approx(rating_total/len(ratings)) |
There was a problem hiding this comment.
Interesting use of the approx method
| for movie in friends_watched_list: | ||
| if movie not in user_watched_list: | ||
| if movie in unique_watched_list: | ||
| continue |
| return unique_watched_list | ||
|
|
||
| def get_available_recs(user_data): | ||
| friend_watched_list = (get_friends_unique_watched(user_data)) |
Comment on lines
+139
to
+152
| if user_data["watched"] != []: | ||
| for movie in friends_watched_list: | ||
| if movie not in user_watched_list: | ||
| recommendation_list.append(movie) | ||
| return recommendation_list | ||
| else: | ||
| return recommendation_list | ||
|
|
||
| def get_rec_from_favorites(user_data): | ||
| friends_watched = get_friends_watched(user_data) | ||
| available_recs_list = [] | ||
| user_favorite_list = user_data["favorites"] | ||
|
|
||
| if user_data["watched"] != []: |
There was a problem hiding this comment.
great job checking for an empty list!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Viewing Party Project