Scissors - Melissa #51
Conversation
jmaddox19
left a comment
jmaddox19
left a comment
There was a problem hiding this comment.
Great work!
If you have the space, it may be worth trying to take 30-60 minutes to try to rewrite get_new_rec_by_genre to use one or two methods you've previously written to DRY up the code a bit, just to get practice with that.
| # function takes 2 parameters: user_data, title | ||
| # user_data ==> dictionary: key: watchlist, watched; value: [] | ||
| # title ==> string (title of movie user has watched) |
There was a problem hiding this comment.
This could be a really useful docstring if you want to practice using those in the future!
| # IF title of movie is IN user's watchlist: | ||
| # remove movie from WATCHLIST | ||
| # ADD movie to WATCHED | ||
| # return user_data | ||
| # IF title of movie IS NOT IN user's watchlist: | ||
| # return user_data |
There was a problem hiding this comment.
I love that you wrote pseudocode first! That said, its usually preferred that you remove pseudocode comments like this before committing and/or submitting your code.
| # create dictionary to determine user's msot frequent genre type | ||
| user_genre_frequency = {} | ||
| for type in user_genre: | ||
| if type not in user_genre_frequency: | ||
| user_genre_frequency[type] = 1 | ||
| else: | ||
| user_genre_frequency[type] += 1 |
There was a problem hiding this comment.
This code is repeated from a previous method. Situations like this are a great chance to practice writing DRY code by calling methods that are already written
2 participants
No description provided.