Paper - Courtney M #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
May 20, 2021
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Excellent job!
Your code was really clear and well organized and it seems like you put a lot of thought behind it. Well done!
Comment on lines
+12
to
+15
| def is_complete(self): | ||
| if self.completed_at: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
You can simplify this as:
Suggested change
| def is_complete(self): | |
| if self.completed_at: | |
| return True | |
| return False | |
| def is_complete(self): | |
| return bool(self.completed_at) |
| tasks = Task.query.order_by(desc(Task.title)) | ||
| else: | ||
| tasks = Task.query.all() | ||
| tasks_response = [task.to_dict() for task in tasks] |
There was a problem hiding this comment.
Nice use of a list comprehension here. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.