tyclaire #54
Open
tyclaire #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaddox19
reviewed
Jul 1, 2021
jmaddox19
left a comment
jmaddox19
left a comment
There was a problem hiding this comment.
Up until Wave 3, everything looks good!
It looks like you didn't have time to figure out what was going wrong with wave 3. I'm glad you just submitted what you had!
| setPlayer(PLAYER_1); | ||
| } | ||
|
|
||
| const winner = winnerIs(); |
There was a problem hiding this comment.
We really need a piece of state for winner so that weird things don't happen with this variable.
|
|
||
| const onClickCallback = (clickedSquare) => { | ||
| const newSquares = []; | ||
| if (winner !== '') { |
There was a problem hiding this comment.
In addition to issues that are arising because the winner isn't tracked as part of the state, this is triggering as true after the first move because the function returns null when there's no winner while this code is looking for an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's all in the title holy cow ty