Leah - Water #48
Open
Leah - Water #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 23, 2020
Collaborator
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nicely done Leah, you hit the learning goals here. Great work!
Comment on lines
+9
to
11
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def length(array) |
Comment on lines
+21
to
23
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def print_array(array) |
Collaborator
There was a problem hiding this comment.
👍 , this mostly makes a copy of the list instead, but you are correct in time/space complexity.
Comment on lines
+42
to
44
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def search(array, length, value_to_find) |
Comment on lines
+58
to
60
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def find_largest(array, length) |
Comment on lines
+74
to
76
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def find_smallest(array, length) |
Comment on lines
+90
to
92
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def reverse(array, length) |
| raise NotImplementedError | ||
| i = 0 | ||
| while i < (length/2) | ||
| pp i |
Collaborator
There was a problem hiding this comment.
Debugging statement not needed in the submission.
Suggested change
| pp i |
Comment on lines
+108
to
110
| # Time complexity: O(log n) | ||
| # Space complexity: O(1) | ||
| def binary_search(array, length, value_to_find) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this is late -- I think I finally grasped the algorithmic efficiency after another read through, so I was just able to complete both parts now.