Earth - Kal #39
Open
Earth - Kal #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 27, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Kal, you hit the learning goals here. Well done. I had some feedback, take a look and let me know what questions you have.
| raise NotImplementedError | ||
| length = self.length | ||
|
|
||
| return nil if index > length |
There was a problem hiding this comment.
This would fix the failing test
Suggested change
| return nil if index > length | |
| return nil if index >= length | |
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+29
to
31
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
42
to
44
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+61
to
63
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+179
to
181
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Comment on lines
199
to
201
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_last |
There was a problem hiding this comment.
👍 , I assume now you know the time/space complexity
Comment on lines
222
to
224
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def find_nth_from_end(n) |
| # returns true if a cycle is found, false otherwise. | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def has_cycle |
Comment on lines
+268
to
+270
| return nil if @head.nil? | ||
|
|
||
| current_node = @head |
There was a problem hiding this comment.
I think here you'll need to check if head is nil, then insert first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.