Earth | Ana #31
Open
Earth | Ana #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 23, 2021 23:15
…, get_first, add_last, length, get_at_index, delete and visit.
CheezItMan
reviewed
Apr 6, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Ana, you hit the main learning goals, but you didn't answer all the space/time complexities. Other than that, well done.
Comment on lines
+21
to
23
| # Time Complexity: 0(1) | ||
| # Space Complexity: 0(1) | ||
| def add_first(value) |
Comment on lines
+30
to
32
| # Time Complexity: 0(n) | ||
| # Space Complexity: 0(1) | ||
| def search(value) |
Comment on lines
+47
to
49
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def find_max |
There was a problem hiding this comment.
This works, but the space complexity is O(1).
Comment on lines
+68
to
70
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+89
to
91
| # Time Complexity: 0(n) | ||
| # Space Complexity: 0(1) | ||
| def get_first |
There was a problem hiding this comment.
This works, but both the time and space complexity are O(1).
Comment on lines
131
to
133
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def get_at_index(index) |
Comment on lines
+148
to
150
| # Time Complexity: o(n) | ||
| # Space Complexity: o(1) | ||
| def visit |
Comment on lines
+160
to
162
| # Time Complexity: o(n) | ||
| # Space Complexity: o(1) | ||
| def delete(value) |
Comment on lines
+183
to
185
| # Time Complexity: o(n) | ||
| # Space Complexity: o(1) | ||
| def reverse |
Comment on lines
+205
to
207
| # Time Complexity: o(n) | ||
| # Space Complexity: o(1) | ||
| def get_last |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the assignment.