Water - Mackenzie #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 24, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Mackenzie, you hit the learning goals here on the methods you wrote. Well done.
You do have a few methods left to do however.
Comment on lines
+159
to
161
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def get_at_index(index) |
There was a problem hiding this comment.
Just noting this isn't done and the ones below.
Comment on lines
+140
to
142
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def length |
Comment on lines
+122
to
124
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def add_last(value) |
There was a problem hiding this comment.
👍 , however the space complexity is O(1) because you're not creating new nodes.
Comment on lines
+108
to
110
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
77
to
81
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def find_min |
Comment on lines
53
to
55
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
Comment on lines
+35
to
37
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def search(value) |
There was a problem hiding this comment.
👍 , however the space complexity is O(1) because you're not creating new nodes here.
Comment on lines
+21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.