forked from AdaGold/binary-and-decimal
-
Notifications
You must be signed in to change notification settings - Fork 54
Earth - Ringo #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ringolingo
wants to merge
1
commit into
Ada-C14:master
Choose a base branch
from
ringolingo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Earth - Ringo #45
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,20 @@ | ||
| # A method named `binary_to_decimal` that receives as input an array of size 8. | ||
| # The array is randomly filled with 0’s and 1’s. | ||
| # The most significant bit is at index 0. | ||
| # The least significant bit is at index 7. | ||
| # Calculate and return the decimal value for this binary number using | ||
| # the algorithm you devised in class. | ||
| def binary_to_decimal(binary_array) | ||
| raise NotImplementedError | ||
| decimal = 0 | ||
| binary_array.reverse.each_with_index do |bit, index| | ||
| unit = bit * 2 ** index | ||
| decimal += unit | ||
| end | ||
| return decimal | ||
| end | ||
|
|
||
| def decimal_to_binary(decimal_number) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| binary_value = [] | ||
| while decimal_number > 0 | ||
| binary_value << (decimal_number % 2) | ||
| decimal_number = (decimal_number / 2) | ||
| end | ||
| until binary_value.length == 8 | ||
| binary_value << 0 | ||
| end | ||
| return binary_value.reverse | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but can you do it without the Enumerable
reversemethod?