Make with_deleted work with paranoid join records #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing tests are not structured very logically, and the combination of using method names to indicate what is being tested, and having loads of assertions per test, makes it difficult to see what each test aims to demonstrate. Future tests will use minitest/spec so tests can be grouped within test files and described clearly.
This is the more customary naming, it distinguishes the tests more clearly from the test helper, and matches the naming of the test classes.
mvz
force-pushed
the
issue-337-has-many-through-paranoid
branch
from
ca974fa to
524924a
Compare
This uses minitest-stub-const to avoid having to create multiple sets of ActiveRecord classes to test with.
Paranoid join records are currently not included in the scope for a many-to-many association using has_many through:.
- Use minitest-around to set up the const stubbing only once in an around block - Group preparatory record creation into a before block - Inline the author.reload call
mvz
force-pushed
the
issue-337-has-many-through-paranoid
branch
from
524924a to
f7e44a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337.
_testwith_deletedinclude deleted join table records withhas_many through: