Replace archiver library #3729
Draft
Replace archiver library #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return File{}, fmt.Errorf("archive not opened") | ||
| } | ||
|
|
||
| header, err := tgz.reader.Next() |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
MDrakos
force-pushed
the
miked/archives-patch
branch
from
2f298ec to
4c9b50e
Compare
MDrakos
force-pushed
the
miked/archives-patch
branch
from
4c9b50e to
562cdc5
Compare
| func (f File) getHeaderName() (string, error) { | ||
| var rawName string | ||
| if header, ok := f.Header.(*tar.Header); ok { | ||
| rawName = header.Name |
Check failure
Code scanning / CodeQL
Arbitrary file write extracting an archive containing symbolic links High
| if header, ok := f.Header.(*tar.Header); ok { | ||
| rawName = header.Name | ||
| } else if header, ok := f.Header.(zip.FileHeader); ok { | ||
| rawName = header.Name |
Check failure
Code scanning / CodeQL
Arbitrary file write extracting an archive containing symbolic links High
| } | ||
|
|
||
| // Access file object - path validation happens immediately after | ||
| file := z.reader.File[z.currentFile] |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.