Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed changes
This pull request introduces a code quality improvement across the codebase by enforcing strict type checking. The
declare(strict_types=1);directive is added at the top of all PHP files, which helps catch type-related bugs early and ensures better type safety throughout the project.Code quality and type safety improvements:
declare(strict_types=1);to all configuration files, includingconfig/corppass-login.php,config/myinfo.php,config/ndi.php, andconfig/singpass-login.php, to enforce strict type checking in configuration logic. [1] [2] [3] [4]database/factories/UserFactory.php,database/migrations/add_corppass_entity_id_to_users_table.php, anddatabase/migrations/add_nric_to_users_table.php, with strict types declaration. [1] [2] [3]src/DTOs,src/Events, andsrc/Exceptionsdirectories (e.g.,FapiCallbackResult.php,ProviderConfig.php,CorpPassDataRetrievedEvent.php,AuthFlowException.php, etc.). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]routes/web.php.These changes help improve code reliability and maintainability by making type errors more visible during development and testing.
Checklist
New feature,Bugfix,Breaking change,Refactoring,DevOps, orDocumentationon GitHub