Skip to content

fix: selector patch #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: selector patch #2

wants to merge 1 commit into from

Conversation

mediaupstream
Copy link

  • wraps calls to document.querySelectorAll in a try/catch
  • replaces the custom escapeValue method in favor of CSS.escape from cssesc
  • incorporates a couple changes from open PRs on the original optimal-select project

@k2heikkila
Copy link

We're going to leave this on a feature branch to possibly help future merge's with other forks. Audisist points at this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

don't merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mediaupstream @k2heikkila