refactor!: Infrastructure for supporting text formatting changes #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcampbell
force-pushed
the
text-format-infra
branch
from
14f0f47 to
bd41f6b
Compare
DataTriny
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the consumer crate, the functions for the text format unit now do something meaningful. This automatically translates to the format unit in UI Automation text ranges, though we're not yet exposing any attributes.
Also, we now expose word boundaries in terms of start character indices rather than lengths. This allows a single word to span text runs, as with the word "another " (including the trailing space) in the test case. This is the breaking change in this PR.