Improve reliability/readability of bin tests scripts and failure output #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…output The src/test/bin tests have been failing intermittently in the CI checks, and the problem appears to be known instability in CMake's file(DOWNLOAD) when invoked from processes in GitHub actions. The downloaded files occasionally have 0 size. This change brings the test images into the git repo rather than downloading them from https://github.com/AcademySoftwareFoundation/openexr-images at configure time. I did that way originally to avoid repo bloat, so I trimmed the list of files used by the tests, so the additional data is not that signifiant, a few Mb. This also restructures the test scripts to produce more informative output, and restructures the CI steps to make it easier to navigate the logs. Signed-off-by: Cary Phillips <[email protected]>
|
Would it be helpful to define all the image paths at the beginning of each script, rather than scattered throughout the code as they currently are? That would clarify which images are used by which scripts. It would also make future changes like this easier, or to modify scripts to run on a different images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The src/test/bin tests have been failing intermittently in the CI checks, and the problem appears to be known instability in CMake's
file(DOWNLOAD)when invoked from processes in GitHub actions. The downloaded files occasionally have 0 size.This change brings the test images into the git repo rather than downloading them from
https://github.com/AcademySoftwareFoundation/openexr-images at configure time. I did that originally to avoid repo bloat, but it's unreliable. I trimmed the list of files used by the tests, so the additional data is not that significant, a few Mb.
This also restructures the test scripts to produce more informative output, and restructures the CI steps to make it easier to navigate the logs.