Fix: handle invalid dataWindow to prevent Python crash (#2023)

src/wrappers/python/PyOpenEXR.cpp

@@ -1040,9 +1040,34 @@ PyFile::write(const char* outfilename)
 
         for (auto a : P.header)
         {
-            auto name = py::str(a.first);
-            py::object second = py::cast<py::object>(a.second);
-            insertAttribute(header, name, second);
+            std::string name   = a.first.cast<std::string> ();
+            py::object  second = py::cast<py::object> (a.second);
+
+            if (name == "compression")
+            {
+                header.compression () = second.cast<Compression> ();
+            }
+            else if (name == "type")
+            {
+                header.setType (second.cast<std::string> ());
+            }
+            else if (name == "lineOrder")
+            {
+                header.lineOrder () = second.cast<LineOrder> ();
+            }
+            else if (name == "tiles")
+            {
+                header.setTileDescription (second.cast<TileDescription> ());
+            }
+            else if (name == "dataWindow")
+            {
+                header.dataWindow () = second.cast<Box2i> ();
+            }
+            else
+            {
+                // Handle other attributes
+                insertAttribute (header, name, second);
+            }
         }
 
         //

src/wrappers/python/tests/test_exceptions.py

@@ -118,6 +118,21 @@ def test_Part(self):
         self.assertEqual(p.type(), OpenEXR.tiledimage)
         self.assertEqual(p.compression(), OpenEXR.NO_COMPRESSION)
 
+    def test_InvalidDataWindow(self):
+        """Test that an invalid dataWindow raises an exception."""
+
+        invalid_header = {
+            "dataWindow": (-5, -5, -1, -1),  # Invalid rectangle
+            "compression": OpenEXR.ZIP_COMPRESSION,
+            "type": OpenEXR.scanlineimage
+        }
+
+        RGB = np.random.rand(10, 10, 3).astype(np.float32)  # Valid shape for data
+
+        with self.assertRaises(Exception):
+            with OpenEXR.File(invalid_header, {"RGB": RGB}) as outfile:
+                outfile.write("invalid_output.exr")
+
     def test_Channel(self):
 
         with self.assertRaises(Exception):

src/wrappers/python/tests/test_readme.py

@@ -31,8 +31,8 @@ def test_write_RGB():
 
     # Generate a 3D NumPy array for RGB channels with random values
     height, width = (20, 10)
-    RGB = np.random.rand(height, width, 3).astype('f')
-
+    RGB = np.random.rand(height, width, 3).astype(np.float32)
+    
     channels = { "RGB" : RGB }
     header = { "compression" : OpenEXR.ZIP_COMPRESSION,
                "type" : OpenEXR.scanlineimage }
@@ -122,27 +122,28 @@ def test_multipart_write():
 
     height, width = (20, 10)
 
-    Z0 = np.zeros((height, width), dtype='f')
+    Z0 = np.zeros((height, width), dtype=np.float32)
     P0 = OpenEXR.Part(header={"type" : OpenEXR.scanlineimage },
                       channels={"Z" : Z0 })
 
-    Z1 = np.ones((height, width), dtype='f')
+    Z1 = np.ones((height, width), dtype=np.float32)
     P1 = OpenEXR.Part(header={"type" : OpenEXR.scanlineimage },
                       channels={"Z" : Z1 })
 
-    f = OpenEXR.File(parts=[P0, P1])
-    f.write("readme_2part.exr")
+    with OpenEXR.File(parts=[P0, P1]) as f:
+        f.write("readme_2part.exr")
 
     with OpenEXR.File("readme_2part.exr") as o:
         assert o.parts[0].name() == "Part0"
         assert o.parts[0].type() == OpenEXR.scanlineimage
-        assert o.parts[0].width() == 10
-        assert o.parts[0].height() == 20
+        assert o.parts[0].width() == width
+        assert o.parts[0].height() == height
         assert np.array_equal(o.parts[0].channels["Z"].pixels, Z0)
+
         assert o.parts[1].name() == "Part1"
         assert o.parts[1].type() == OpenEXR.scanlineimage
-        assert o.parts[1].width() == 10
-        assert o.parts[1].height() == 20
+        assert o.parts[1].width() == width
+        assert o.parts[1].height() == height
         assert np.array_equal(o.parts[1].channels["Z"].pixels, Z1)
 
     print("ok")