Improvements to convert node tables
#2740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist makes improvements to the specification tables for the `convert` node, aligning them more accurately with the standard data libraries, and expressing the type variations of the node more compactly. With these changes, the number of differences between the standard node specification and data libraries reported by `comparenodedefs.py` is reduced from 46 to 38.
jstone-lucasfilm
merged commit 834edcf
into
AcademySoftwareFoundation:main
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist makes improvements to the specification tables for the
convertnode, aligning them more accurately with the standard data libraries, and expressing the type variations of the node more compactly.With these changes, the number of differences between the standard node specification and data libraries reported by
comparenodedefs.pyis reduced from 46 to 38.