Apply comparenodedefs.py to PBR Nodes
#2738
Merged
+39
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist adds a new GitHub CI step to compare the PBR Nodes specification and PBR data libraries using comparenodedefs.py. Based on the results of the new GitHub CI step, several minor improvements to the PBR Nodes specification have been made: - Update the data type of `absorption` inputs from `color3` to `vector3` to match the data libraries. - Update the name of `absorption` outputs to match the data libraries. - Move the `displacement` node from Standard Nodes to PBR Nodes to match the data libraries. Additionally, this changelist adds support for the `or` conjunction in `comparenodedefs.py`, interpreting it in the same fashion as a comma.
jstone-lucasfilm
changed the title
comparenodedefs.py to PBR Nodes
niklasharrysson
approved these changes
Jan 4, 2026
Contributor
niklasharrysson
left a comment
niklasharrysson
left a comment
There was a problem hiding this comment.
This looks good to me!
Just a comment that it seams more appropriate to have the displacement node located in stdlib. Not for this PR, but perhaps we should move it there consistently (nodedef, code and spec) in a future PR.
Member
Author
|
That's a good point, @niklasharrysson, and @dbsmythe mentioned the same issue in a side thread. For now, I'd be happy to leave the With that approach, our |
jstone-lucasfilm
merged commit 6882b34
into
AcademySoftwareFoundation:main
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist adds a new GitHub CI step to compare the PBR Nodes specification and PBR data libraries using comparenodedefs.py.
Based on the results of the new GitHub CI step, several minor improvements to the PBR and Standard Nodes specifications have been made:
absorptioninputs fromcolor3tovector3to match the data libraries.absorptionoutputs to match the data libraries.intensityinput of thelightnode to match the data libraries.displacementnode, but leave it in the Standard Nodes specification.Additionally, this changelist adds support for the
orconjunction incomparenodedefs.py, interpreting it in the same fashion as a comma.