Add OSL hextiling implementations #2734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist adds implementations of `hextiledimage` and `hextilednormalmap` to OSL, making these nodes available across all shading languages that MaterialX supports. The new OSL implementations closely follow the existing GLSL versions, with minor improvements to take better advantage of OSL channel indexing and loops. Additionally, the `standard_surface_onyx_hextiled.mtlx` example has been moved to `Examples/StandardSurface`, making it more visible to users of the MaterialX Web Viewer and other tools.
Member
Author
|
Here's a new set of reference quality GLSL/OSL render comparisons, including the comparison of |
lgritz
reviewed
Dec 23, 2025
This changelist updates the OSL implementation of hextiling to use the native texture coordinate derivatives in OSL, as suggested by Masuo Suzuki.
Contributor
|
LGTM! |
lgritz
reviewed
Jan 7, 2026
Member
Author
|
Here's a new set of reference quality GLSL/OSL render comparisons, using the latest updates to this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist adds implementations of
hextiledimageandhextilednormalmapto OSL, making these nodes available across all shading languages that MaterialX supports.The new OSL implementations closely follow the existing GLSL versions, with minor improvements to take better advantage of OSL channel indexing and loops.
Additionally, the
standard_surface_onyx_hextiled.mtlxexample has been moved toExamples/StandardSurface, making it more visible to users of the MaterialX Web Viewer and other tools.