Convert our unit tests and perf harness to use native entry-points #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture in C++ to be able to run the tests we want to run.
…st integration (which starts a separate process for each test) way too slow, likely due to CoreCLR startup.
…iles so we aren't allocating a ton and slowing down test discovery and execution.
…t in Regression.Locator
…sing IMetaDataEmit instead of using Roslyn to remove another managed dependency.
…y timeout for windows
|
I still have some work to get macOS passing, but think enough work is done for a first look. |
|
I can't reproduce the mac failures locally... I'll try to figure out what's going on. |
|
Okay looks like the problem is that hostfxr doesn't find runtimes/frameworks/sdks in its installation if that is not a global installation and the path is not specified. macOS is the only platform where the install path isn't the default path. I'll try to figure out a good solution here. |
jkoritzinsky
commented
Jan 2, 2024
AaronRobinsonMSFT
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our unit tests and perf harness are both C#-based (xUnit, BenchmarkDotNet) but do almost all of their work in native code.
This PR changes our tests to instead use GoogleTest and Google Benchmark and be fully-native test apps.
The only remaining managed code is the Regression.TargetAssembly app that is used for the FindAPIs test and the code to locate CoreCLR (done so using a DNNE-based API).I've moved the .NET Framework install lookup and the "generate an image with indirection tables" functionality into the native code.
I'm still exploring how to move the CoreCLR locating APIs to C++. I'd like to use nethost and the hostfxr APIs to avoid starting up CoreCLR just to get its location, but it is difficult to use nethost without moving to vcpkg (right now I'm using FetchContent to pull in dependencies manually).CoreCLR lookup is done with the nethost APIs from the current .NET installation (to avoid using vcpkg).
Test exploration/execution inner-loop still works very well in this world. The "Testing" pane on VSCode populates with all of the tests when the CMake extension is installed and configured, and the Test Explorer in VS populates when you open the DNMD project in the CMake targets view.
This PR updates the C++ standard version used in the tests to C++17 to get the standard filesystem APIs. I can move away from using these APIs, but then we'll need to provide a separate PAL for them (which I wanted to avoid for the first implementation to focus on getting things to work).