Add fuel tank leak parameter #1147
Conversation
| bool updateOnly = true; //!< -- Sets whether to use update only mass depletion | ||
| Message<FuelTankMsgPayload> fuelTankOutMsg{}; //!< -- fuel tank output message name | ||
| FuelTankMsgPayload fuelTankMassPropMsg{}; //!< instance of messaging system message struct | ||
| double fuelLeakRate{}; //!< [kg/s] rate of fuel leaking from tank; does not produce force |
There was a problem hiding this comment.
I don't want to just make this a public variable that gets set from python. I think it would be cleaner to have this as an optional input message. If it is connected, then we read in this rate and set this now private variable. This way, if the rate of fuel usage changes, this can be set via the input message?
There was a problem hiding this comment.
Do you propose a new type of message to handle this? Currently the fuel tank takes no input messages since it's connected to the thrusters at a deeper level than the messaging system, so there's no obvious existing message type to include this in.
There was a problem hiding this comment.
Yes, we can have a flowRate message type? This would make this implementation much more flexible.
Description
Adds the
fuelLeakRateparameter to fuel tanks to simulate a loss of fuel without imparting momentum on the spacecraft.Verification
Added unit test for new feature.
Documentation
Documented in .h file and release notes.
Future work
None.