Aitutu: Updating the workload to add support for the Samsung devices … #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please fix the commit message. |
marcbonnici
requested changes
Jul 5, 2019
Contributor
marcbonnici
left a comment
marcbonnici
left a comment
There was a problem hiding this comment.
Could you also add a description in the commit message of what popup this is dismissing on Samsung devices?
|
|
||
| UiObject next = mDevice.findObject(selector.textContains("NEXT") | ||
| .className("android.widget.Button")); | ||
| next.waitForExists(60000); |
Contributor
There was a problem hiding this comment.
60 seconds seems to be a very long timeout for something that is only present on some devices. Is there an extra 0 here?
|
|
||
| UiObject cancel = mDevice.findObject(selector.textContains("CANCEL") | ||
| .className("android.widget.Button")); | ||
| cancel.waitForExists(60000); |
Contributor
There was a problem hiding this comment.
Could this also be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that do not seem to dismiss the next button like other devices.