⚙️ [config] Add tests for service configurations with embedded structs tagged with mapstructure:",squash"
#715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kem-Gov
changed the title
[config] Automatically flatten embedded struct fields[config] Automatically flatten embedded struct fields on service configurations
Kem-Gov
changed the title
[config] Automatically flatten embedded struct fields on service configurations[config] Add tests for service configurations with embedded structs tagged with mapstructure:",squash"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests to ensure that service configurations with embedded struct fields that are tagged with
mapstructure:",squash"will be flattened and mapped correctly.It tests configuration mapping from both environment variables as well as from file.
Test Coverage