Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflow Refactor #96

Merged
merged 3 commits into from
Jan 4, 2025
Merged

CI Workflow Refactor #96

merged 3 commits into from
Jan 4, 2025

Conversation

tareknaser
Copy link
Collaborator

This PR refactors the CI workflows. The biggest change is moving Java bindings to a separate job that only runs if the "Build and Test" jobs pass.
Related discussion: #94 (comment)

What’s New:

  • Java bindings now run as a separate job after all the build and test jobs are done.
  • Weekly Testing workflow is simplified with a matrix so we don’t repeat the same steps for each platform.
  • Benchmarks now run only if Java bindings pass and it’s a pull request.

Why This Approach?

  • Benchmarks
    • Tried keeping benchmarks in a separate workflow using workflow_run, but ran into issues with getting the branchName and commenting on PRs.
  • Java Bindings

Current CI Setup:

Screenshot 2024-12-20 at 1 39 27 AM

Examples from my fork:

  • Push to Main: Benchmarks are skipped
    Run Example
  • Pull Request: Everything runs as expected, including benchmarks
    Run Example

Copy link
Collaborator

@Pushkarm029 Pushkarm029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean✨

@kirillt kirillt merged commit 14b2fff into patch-1 Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants