[bje-load-exceptions] keep loading after bad objects #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm
approved these changes
Sep 20, 2017
|
Is there a test that covers this and if not, is it worthwhile writing one? |
|
@LiamMaru Not sure if tests are possible for this. Byron might be able to elaborate more on what the actual bug was. |
|
It is worthwhile writing one, because I'm not actually 100% sure this really fixes it. It's subtle. It's sneaky. I can (and have, since reading this) written a "does no harm" test to show this doesn't prevent valid operation, but it's possible I simply didn't isolate the real bug effectively enough when trying to diagnose it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where loading will stop having any effect after the first error encountered.