Skip to content

Sticky nav #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rajaryan99 wants to merge 2 commits into from
Closed

Sticky nav #655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4ae15
sicky nav feature added
Rajaryan99 Mar 12, 2026
c17d192
fixed the issue lable and classname issue
Rajaryan99 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/shared/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ function MobileNavigation(props) {
Navigation
</h2>
</div>
<nav className="mt-6">
<nav className="">
<ul className="-my-2 font-mono font-black divide-y divide-zinc-100 text-base text-zinc-800 dark:divide-zinc-100/5 dark:text-zinc-300">
<MobileNavItem href="/about">About</MobileNavItem>
<MobileNavItem href="/about">About </MobileNavItem>
Comment on lines +124 to +126
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clean up the no-op nav prop and accidental label whitespace.

Line 124’s empty className can be dropped, and Line 126’s trailing space makes the mobile label differ from the desktop one for no benefit. This is small, but it keeps the markup cleaner and avoids brittle text matching later.

Suggested cleanup 
-            <nav className="">
+            <nav>
               <ul className="-my-2 font-mono font-black divide-y divide-zinc-100 text-base text-zinc-800 dark:divide-zinc-100/5 dark:text-zinc-300">
-                <MobileNavItem href="/about">About </MobileNavItem>
+                <MobileNavItem href="/about">About</MobileNavItem>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<nav className="">
<ul className="-my-2 font-mono font-black divide-y divide-zinc-100 text-base text-zinc-800 dark:divide-zinc-100/5 dark:text-zinc-300">
<MobileNavItem href="/about">About</MobileNavItem>
<MobileNavItem href="/about">About </MobileNavItem>
<nav>
<ul className="-my-2 font-mono font-black divide-y divide-zinc-100 text-base text-zinc-800 dark:divide-zinc-100/5 dark:text-zinc-300">
<MobileNavItem href="/about">About</MobileNavItem>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/components/shared/Header.jsx` around lines 124 - 126, Remove the no-op
empty className attribute on the <nav> element and trim the accidental trailing
space in the MobileNavItem label for "/about" so the text matches the desktop
label; update the JSX in Header.jsx by deleting the empty className="" on the
nav node and changing MobileNavItem href="/about">About </MobileNavItem to
MobileNavItem href="/about">About</MobileNavItem.

<MobileNavItem href="/projects">Projects</MobileNavItem>
<MobileNavItem href="/ideas">Ideas</MobileNavItem>
<MobileNavItem href="/apply">Apply</MobileNavItem>
Expand Down