build: bump tokenizers to >=0.21.0 for Windows ARM64 support#79
build: bump tokenizers to >=0.21.0 for Windows ARM64 support#79Komatlakarthik wants to merge 2 commits intoAOSSIE-Org:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 17: Update the tokenizers dependency constraint in pyproject.toml to
include an upper bound for stability: change the current "tokenizers>=0.21.0"
entry to a bounded spec such as "tokenizers>=0.21.0,<0.22.0" (or
"tokenizers>=0.21.0,<1.0.0" if you prefer a wider but still safe range) so
future breaking releases won't be pulled automatically; edit the tokenizers line
in pyproject.toml accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c887b97a-46cc-4052-a73a-1f90b7e03859
📒 Files selected for processing (1)
pyproject.toml
Problem
tokenizers==0.15.2has no pre-built wheel for Windows ARM64 (Snapdragon X Elite). This causeslink.exebuild errors and blocks all Windows ARM64 contributors from setting up the project.Fix
Relaxed the pin from
==0.15.2to>=0.21.0,<1.0.0. Version0.21.0and above ship official ARM64 Windows wheels on PyPI, enabling seamless installation on newer hardware.Verified on
uv run pytest tests/ -v)Impact
Unblocks Windows ARM64 contributors — an increasingly common hardware platform (Microsoft Copilot+ PCs). This improves the project's accessibility and developer experience for modern Windows environments.
Checklist
Summary by CodeRabbit