-
Notifications
You must be signed in to change notification settings - Fork 181
Feature/chatbot integration #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
4da995e
619f550
0edf12d
5cbe811
5b803c2
636644c
4e92493
e7af19c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| function Explorer() { | ||
| return ( | ||
| <div style={{ padding: "20px" }}> | ||
| <h2>Explorer</h2> | ||
| <p>Blockchain explorer coming soon.</p> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| export default Explorer; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,4 +87,4 @@ def chat(): | |
| return jsonify({"error": str(e)}) | ||
|
|
||
| if __name__ == '__main__': | ||
| app.run(host="0.0.0.0", port=5000,debug=True) | ||
| app.run(host="0.0.0.0", port=5000,debug=True) | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation doesn't reject empty proposals after trimming.
The validation only counts commas but doesn't verify that trimmed proposals are non-empty. Input like
"proposal1, , , proposal2"or" , , "would pass validation but result in empty proposal strings.Filter and validate trimmed proposals.
🔎 Proposed fix
const isFormValid = () => { - return proposals.split(',').length >= 2; + const trimmedProposals = proposals.split(',').map(p => p.trim()).filter(p => p.length > 0); + return trimmedProposals.length >= 2; };📝 Committable suggestion
🤖 Prompt for AI Agents