Skip to content

fix: Prevent election creation with past start dates #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sai-suraj143 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Prevent election creation with past start dates #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion client/app/create/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,18 @@ const CreatePage: React.FC = () => {
const [endTime, setEndTime] = useState<Date | null>(new Date());
const [candidates,setCandidates] = useState<Candidate[]>([])
const changeChain = () => {
// TRAINER FIX: Check if a Wallet is actually installed first!
if (typeof window !== "undefined" && !(window as any).ethereum) {
toast.error("No Crypto Wallet Found!");
alert("Please install MetaMask to continue.");
window.open("https://metamask.io/download/", "_blank");
return;
}

// If wallet exists, proceed with the switch
switchChain({ chainId: sepolia.id });
}
interface Candidate {
interface Candidate {
name: string;
description: string;
}
Expand Down Expand Up @@ -68,6 +77,12 @@ const CreatePage: React.FC = () => {

const start = BigInt(Math.floor(startTime.getTime() / 1000));
const end = BigInt(Math.floor(endTime.getTime() / 1000));
// FIX: Check if start time is in the past
const now = BigInt(Math.floor(Date.now() / 1000));
if (start < now) {
toast.error("Invalid timing. Start time cannot be in the past.");
return;
}

if (start >= end) {
toast.error("Invalid timing. End time must be after start time.");
Expand Down