Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: print build timings even if no previous build succeeded #23

Merged
merged 1 commit into from
May 7, 2024

Conversation

jiegec
Copy link
Member

@jiegec jiegec commented Apr 2, 2024

If the first package failed to build, the build timings summary is not shown. This pull requests change the code to always show the summary.

Copy link

what-the-diff bot commented Apr 2, 2024

PR Summary

  • Simplified Code Structure

    This update removes an extra verification step in our system. Previously, the code would check whether 'build_timings' was present before calling the 'print_build_timings' function. With this change, our system is streamlined, eliminating unnecessary checks, and hence, this could potentially improve our system's overall performance.

@jiegec
Copy link
Member Author

jiegec commented Apr 2, 2024

If we want to guard against null instead of [], we may want to use a stricter check.

@jiegec jiegec requested a review from liushuyu April 2, 2024 03:24
@MingcongBai MingcongBai merged commit 6dd864b into production May 7, 2024
1 check passed
@KexyBiscuit KexyBiscuit deleted the remove-empty-timing-check branch July 21, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants