Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENH: Add shared RegAdam infrastructure for DiReCT
ENH: Share RegAdam via antstorch.registration; scaffold antstorch.direct.
RegAdam.step() and _fit_syn_level()) into reg_adam_direction()/
RegAdamState in a new antstorch.registration package, so higher-level
models (SyN, and eventually DiReCT) share one implementation instead of
depending on each other's private modules.
longer silently falls through to Gaussian smoothing when regularizer is
'dsti'/'dsti1'/'none' (old condition only excluded 'sobolev'); now
requires regularizer == 'gaussian' explicitly. Covered by a new
regression test that fails if Gaussian smoothing is invoked for those
regularizers.
implementation yet) with a README defining module boundaries and two
reuse rules for whoever writes core.py/regularization.py next:
regularization.py must share antstorch.syn.core.smoothing rather than
reimplement Gaussian/Sobolev/DST-I/B-spline filtering, and
antstorch.direct must never be re-exported as antstorch.cortical_thickness
/ antstorch.longitudinal_cortical_thickness, since those names are
already public API in antstorch.utilities.cortical_thickness.