Skip to content

Fix: ZK-011: Add explicit domain separation tags to note commitme #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linbo328 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: ZK-011: Add explicit domain separation tags to note commitme #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Example:
```typescript
/**
* Generates a new note for depositing into the privacy pool.
*
*
* @returns A note containing nullifier, secret, and commitment
*/
export async function generateNote(): Promise<Note> {
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,11 @@ cargo test # Run unit and integration tests

## Current Status

✅ Circuits: Commitment, withdrawal, and merkle circuits implemented
✅ Contracts: Full privacy pool contract with deposit/withdraw/admin functions
✅ Analytics: Privacy-preserving aggregate analytics + public dashboard scaffold
🚧 SDK: TypeScript client SDK (planned)
🚧 Frontend: Next.js dApp (planned)
✅ Circuits: Commitment, withdrawal, and merkle circuits implemented
✅ Contracts: Full privacy pool contract with deposit/withdraw/admin functions
✅ Analytics: Privacy-preserving aggregate analytics + public dashboard scaffold
🚧 SDK: TypeScript client SDK (planned)
🚧 Frontend: Next.js dApp (planned)
🚧 Scripts: Deployment automation (planned)

## Privacy-Preserving Analytics
Expand Down
6 changes: 3 additions & 3 deletions contracts/privacy_pool/VK_METADATA_QUICK_REF.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,17 @@ const vk = {

### CircuitIdMismatch (Error 52)

**Cause**: VK circuit_id doesn't match expected circuit
**Cause**: VK circuit_id doesn't match expected circuit
**Fix**: Deploy correct VK for this circuit

### PublicInputCountMismatch (Error 53)

**Cause**: Proof has different number of inputs than VK expects
**Cause**: Proof has different number of inputs than VK expects
**Fix**: Regenerate proof with matching circuit version

### MalformedVerifyingKey (Error 51)

**Cause**: gamma_abc_g1 length doesn't match public_input_count + 1
**Cause**: gamma_abc_g1 length doesn't match public_input_count + 1
**Fix**: Regenerate VK from circuit artifacts

## Client-Side Validation
Expand Down
6 changes: 3 additions & 3 deletions docs/zk_artifacts_layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ Artifact versions are tracked via the `version` field in `sdk/src/artifacts.ts`.
The SDK uses the centralized path configuration in `sdk/src/artifacts.ts`:

```typescript
import {
getKnownCircuitPath,
import {
getKnownCircuitPath,
CIRCUIT_NAMES,
ZK_ARTIFACT_VERSION
ZK_ARTIFACT_VERSION
} from './artifacts';

// Get current version withdraw circuit
Expand Down