replace pybind11 -> nanobind
#9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work but only:
/CC @purepani |
casperdcl
force-pushed
the
nanobind
branch
2 times, most recently
from
1bb96dd to
aad09f2
Compare
purepani
reviewed
May 13, 2025
numcu/CMakeLists.txt
Outdated
Comment on lines
17
to
19
| execute_process( | ||
| COMMAND "${Python_EXECUTABLE}" -m nanobind --cmake_dir | ||
| OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE nanobind_ROOT) |
There was a problem hiding this comment.
You can just delete these lines. scikit-build-core handles adding to the library path for you(see https://scikit-build-core.readthedocs.io/en/latest/guide/getting_started.html)
Suggested change
| execute_process( | |
| COMMAND "${Python_EXECUTABLE}" -m nanobind --cmake_dir | |
| OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE nanobind_ROOT) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pybind11->nanobind-Wpedantic