gfx12xx (RDNA4) regex update#5429
Open
wiersema1 wants to merge 1 commit intoAMReX-Codes:developmentfrom
Open
Conversation
…evices and use the correct wavefront size.
WeiqunZhang
reviewed
May 2, 2026
| add_amrex_define( AMREX_USE_HIP NO_LEGACY ) | ||
| add_amrex_define( NDEBUG ) # This address a bug that causes slow build times | ||
| if (${AMReX_AMD_ARCH} MATCHES "gfx1[01].*") | ||
| if (${AMReX_AMD_ARCH} MATCHES "gfx1[012].*") |
Member
There was a problem hiding this comment.
Suggested change
| if (${AMReX_AMD_ARCH} MATCHES "gfx1[012].*") | |
| if (${AMReX_AMD_ARCH} MATCHES "gfx1???") |
Could you tell me if this works?
Author
There was a problem hiding this comment.
"gfx1???" gives an error during compilation.
CMake Error at Submodules/AMReX/Tools/CMake/AMReXSetDefines.cmake:68 (if):
if given arguments:"gfx1201" "MATCHES" "gfx1???"Regular expression "gfx1???" cannot compile
Call Stack (most recent call first):
Submodules/AMReX/Src/CMakeLists.txt:45 (include)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated regex in Tools/Cmake/AMReXSetDefines.cmake to catch gfx12xx devices and use the correct wavefront size.
Additional background
My build environment includes
Checklist
The proposed changes: