Clang-Tidy: modernize-use-constraints#5372
Draft
WeiqunZhang wants to merge 6 commits intoAMReX-Codes:developmentfrom
Draft
Clang-Tidy: modernize-use-constraints#5372WeiqunZhang wants to merge 6 commits intoAMReX-Codes:developmentfrom
WeiqunZhang wants to merge 6 commits intoAMReX-Codes:developmentfrom
Conversation
Member
|
With this PR and the ranges one it should be tested how it affects compilation time. I have heard that CUDA Thrust still uses iterators instead of ranges due to the increase in compile time. But using concepts might be faster than enable_if. |
WeiqunZhang
force-pushed
the
modernize-use-constraints
branch
from
9b55cb2 to
c8f9024
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.